Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add permission to write logs to CloudWatch by default #741

Closed

Conversation

alaladeakin
Copy link

How to categorize this PR?

/area logging
/kind enhancement
/platform aws

What this PR does / why we need it:
This PR adds CloudWatch permissions to Gardener nodes. With this (default) permission, operators do not need to do anything additional after deploying fluentbit or other logging mechanisms.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Release note:


@alaladeakin alaladeakin requested review from a team as code owners April 27, 2023 20:35
@gardener-robot gardener-robot added area/logging Logging related kind/enhancement Enhancement, improvement, extension platform/aws Amazon web services platform/infrastructure labels Apr 27, 2023
@gardener-robot
Copy link

@alaladeakin Thank you for your contribution.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


C5336947 seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@gardener-robot gardener-robot added needs/review Needs review size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) labels Apr 27, 2023
@gardener-robot-ci-2
Copy link
Contributor

Thank you @alaladeakin for your contribution. Before I can start building your PR, a member of the organization must set the required label(s) {'reviewed/ok-to-test'}. Once started, you can check the build status in the PR checks section below.

@gardener-robot gardener-robot added the lifecycle/stale Nobody worked on this for 6 months (will further age) label Jan 5, 2024
@gardener-robot gardener-robot added lifecycle/rotten Nobody worked on this for 12 months (final aging stage) and removed lifecycle/stale Nobody worked on this for 6 months (will further age) labels Sep 13, 2024
@kon-angelo
Copy link
Contributor

As discussed internally, it would be nice if this was configurable. I will close this PR due to inactivity. Feel free to reopen for discussion.

@kon-angelo kon-angelo closed this Nov 13, 2024
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/logging Logging related kind/enhancement Enhancement, improvement, extension lifecycle/rotten Nobody worked on this for 12 months (final aging stage) needs/review Needs review platform/aws Amazon web services platform/infrastructure size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants